Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fall damage detection module #145

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request implements feature #144 for fall detection. The implementation works by detecting instantaneous accelerations above a given threshold. There are options for:

  • Suppress acceleration/damage caused by the player being launched into the air - for example by jump pads
  • Detect only damage caused by colliding with the ground, as opposed to colliding with a wall

@BastiaanOlij
Copy link
Member

Hmmm, I'm not sure about this one, it's a bit strange implementing specific game logic into a generic toolkit. I need to think about this and whether there is a more generic approach, this has the danger of implementing all sorts of specifics as people want to detect other forms of impacts.

Added fall damage detection module
@Malcolmnixon
Copy link
Collaborator Author

I moved the fall-detector into an "examples" folder and put an extensive comment explaining that it was an example and that games would most likely need to customize it.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jun 20, 2022
@BastiaanOlij BastiaanOlij added this to the 2.5.0 milestone Jun 20, 2022
@BastiaanOlij BastiaanOlij merged commit abc005f into GodotVR:master Jun 20, 2022
@Malcolmnixon Malcolmnixon deleted the fall-damage branch June 20, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants