Added grappling movement provider and fixed disabled/bypassed provider signals #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… signals if disabled or bypassed. Added grapple movement provider.
|
I'll give this a test tomorrow, looking forward to swinging around :) |
|
Just saw the video, excellent work: https://www.youtube.com/watch?v=4R-h3a0wcPY Let me know if you're ready for me to merge this Malcolm? |
|
Yup, this one's ready to go in. Like everything there's bound to be feature requests and improvements ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements feature request #122 by adding the grappling movement provider based on code from teddybear082.
Additionally this pull request contains a fix to how movement providers are serviced. The change allows an active movement provider to detect:
In these circumstances the movement provider is able to deactivate itself sending any finished signals - for example to disable movement sound effects. This was found when firing the grappling hook while gliding and the gliding sound continued to play even though grappling motion had taken over.