Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Function_Turn_movement provider #121

Merged
merged 1 commit into from
May 3, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request extracts the turn logic from Function_Direct_movement and moves it into a Function_Turn_movement provider. The benefits of this are:

  • Simpler and more modular code
  • It's possible to add movement and turning separately
  • Movement can be disabled without disabling turning

The only down-side is that existing code will now have to update the Function_Direct_movement settings, and possibly add a Function_Turn_movement to keep existing player movement behavior.

This pull request implements feature request #115

@BastiaanOlij
Copy link
Member

Sorry for the late response Malcolm, looks good, my only concern, as you already mention, is that this is a breaking change for people using previous versions of the library. Might not be avoidable, I do like this split.

@Malcolmnixon
Copy link
Collaborator Author

I'll push up an update this evening with the VERSIONS.md updated to mention the change.

Extracted turning logic from Function_Direct_movement into a separate movement provider.
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label May 3, 2022
@BastiaanOlij BastiaanOlij added this to the 2.4.0 milestone May 3, 2022
@BastiaanOlij BastiaanOlij merged commit cc16758 into GodotVR:master May 3, 2022
@Malcolmnixon Malcolmnixon deleted the turn-provider branch May 5, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants