Skip to content

Commit

Permalink
[src][jovyan] TODOs for waveforms display
Browse files Browse the repository at this point in the history
  • Loading branch information
Godhart committed May 21, 2024
1 parent 8d0cb14 commit b7459c3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/jovyan/vdf_magic.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ def _show(self, line:str, cell=None):
# TODO: start-time / end-time
extractor.execute()
wave = load_jyt(json_path)
# TODO: it's nice and neat to snow waveforms like this
# but only works in jupyter
# make universal and permanent way
waves_data[wave_group] = f"""
<script type="WaveDrom">
{wave}
Expand Down Expand Up @@ -272,7 +275,7 @@ def _line_magic(self, line:str):
self._vdf_debug(line)

if "#wavedrom" in line:
# TODO: use cdn
# TODO: use cdn / path prefix from os.environ
wave_script_load = ""
wave_script_load += '<script src="https://wavedrom.com/skins/default.js"></script>'
wave_script_load += '<script src="https://wavedrom.com/skins/dark.js"></script>'
Expand Down

0 comments on commit b7459c3

Please sign in to comment.