[Issue #371] Add NetNTLMv2 hash capture to README #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
requested changes
Jan 10, 2022
|
@obilodeau Committed some changes, let me know if everything is OK |
obilodeau
reviewed
Jan 10, 2022
Co-authored-by: Olivier Bilodeau <[email protected]>
If we don't use the NLA redirection feature and the server doesn't support downgrade attacks then the best we can do is steal the hash. Some ASN.1 BER improvements were required as well. Fixes GoSecure#358 Co-authored-by: Olivier Bilodeau <[email protected]>
Improved the situation with GoSecure#294
> TypeError: 'EDecimal' object cannot be interpreted as an integer I wasn't getting those error before, I think it might be python 3.10 related. Flooring gets rid of the error. That information was lost anyway.
Introduced an InetSocketAddress abstraction and adapted all code paths to it.
This was emitting a DeprecationWarning since Python 3.3 but we never saw it... See https://docs.python.org/3/whatsnew/3.9.html#you-should-check-for-deprecationwarning-in-your-code
* fix: make conversion success message uniform * fix: typo in conversion layer sink * Added pcap to json tests, removed worthless Windows test * Added CI/CD tests for pyrdp-convert JSON and replay outputs * pyrdp-convert: Added some exit code propagation on exceptions Co-authored-by: Olivier Bilodeau <[email protected]> Co-authored-by: Alexandre Beaulieu <[email protected]>
…essions. Rebased on master by @obilodeau. Some problems likely remain.
Allows us to run them locally easily
- link to blog posts - mention version where feature introduced - link to cert extraction doc - NLA -> Network Level Authentication - Avoiding confusing NLA vs non-NLA in the MITM sense not server sense (confusing I told you ;) - Fixed log file name
|
Dammit I screwed up, I brought in all changes in master since PR was created by accident... Review can focus on my last commit. |
obilodeau
approved these changes
Jan 17, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@obilodeau Let me know if there's more to be added