feat: Added --no-downgrade mode.
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbl
commented
Mar 13, 2020
obilodeau
approved these changes
Mar 16, 2020
| @@ -306,6 +306,30 @@ After 5 seconds, input / output is restored back to normal. | |||
| #### Other MITM arguments | |||
| Run `pyrdp-mitm.py --help` for a full list of arguments. | |||
|
|
|||
| ##### `--no-downgrade` | |||
There was a problem hiding this comment.
Because of this new section the ToC will need to be regenerated. They used an online tool to do so. It kind of sucks that this is a manual step to be honest. Migrating this file to AsciiDoc would eliminate that problem. That said, just updating the ToC would be fine for now.
Co-Authored-By: Olivier Bilodeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of the
--gdi-passthroughbranch that covers a broader set of passthrough options.After some internal discussion, a mode that avoids fingerprinting by not downgrading any of the connection features makes more sense than per-extension support switches, so I renamed the switch to
--no-downgradeand added some documentation to explain its current state, what it can and cannot do, and its impacts on the PyRDP player.