Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bettercap-rdp-mitm #107

Merged
merged 6 commits into from
Aug 2, 2019
Merged

Updated bettercap-rdp-mitm #107

merged 6 commits into from
Aug 2, 2019

Conversation

Pourliver
Copy link
Contributor

Since PyRDP will be presented at the NSEC 2019, I updated the documentation in regard to bettercap's usage with PyRDP.

@Pourliver Pourliver requested a review from obilodeau May 15, 2019 19:58
Copy link
Collaborator

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started that review a long time ago but things are working well enough now that we are almost there for a merge.

docs/bettercap-rdp-mitm.md Outdated Show resolved Hide resolved
Have fun!
Install Caplets by running these commands :

cd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brought me back in my home dir. Is that intended?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's not a go project so it can be done anywhere... Might as well send users to /tmp/ or ~/src/ or something along those lines. Not the clutter the homedir of n00bs (or we could rm -r caplets/ after).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, even though the basic caplet works as-is, the other one isn't. They aren't meant to be deleted after installation, since they can be modified where they are git cloned, and the second one needs to be modified, else it won't work.. But I agree that bloating the home directory isn't a great idea.

docs/bettercap-rdp-mitm.md Outdated Show resolved Hide resolved
docs/bettercap-rdp-mitm.md Outdated Show resolved Hide resolved
docs/bettercap-rdp-mitm.md Outdated Show resolved Hide resolved
@Pourliver
Copy link
Contributor Author

@Romounet Since you installed the module recently, did the instructions work out of the box? If so, I'd merge this PR.

@Pourliver
Copy link
Contributor Author

I talked with @Romounet on Slack and updated the documentation to remove ambiguity. I also updated the caplets to better explain the possible configurations. Merging.

@Pourliver Pourliver merged commit 036b8f1 into master Aug 2, 2019
@obilodeau obilodeau deleted the bettercap-doc branch November 27, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants