-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated bettercap-rdp-mitm #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started that review a long time ago but things are working well enough now that we are almost there for a merge.
docs/bettercap-rdp-mitm.md
Outdated
Have fun! | ||
Install Caplets by running these commands : | ||
|
||
cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This brought me back in my home dir. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it's not a go project so it can be done anywhere... Might as well send users to /tmp/ or ~/src/
or something along those lines. Not the clutter the homedir of n00bs (or we could rm -r caplets/
after).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, even though the basic caplet works as-is, the other one isn't. They aren't meant to be deleted after installation, since they can be modified where they are git cloned, and the second one needs to be modified, else it won't work.. But I agree that bloating the home directory isn't a great idea.
@Romounet Since you installed the module recently, did the instructions work out of the box? If so, I'd merge this PR. |
I talked with @Romounet on Slack and updated the documentation to remove ambiguity. I also updated the caplets to better explain the possible configurations. Merging. |
Since PyRDP will be presented at the NSEC 2019, I updated the documentation in regard to bettercap's usage with PyRDP.