Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP4 conversion - use proper progress bar #274

Closed
xshill opened this issue Jan 4, 2021 · 0 comments
Closed

MP4 conversion - use proper progress bar #274

xshill opened this issue Jan 4, 2021 · 0 comments
Assignees
@xshill
Labels
enhancement New feature or request

Comments

@xshill
Copy link
Collaborator

xshill commented Jan 4, 2021

Currently, the pyrdp-convert shows a "bouncing ball" type of progress bar, which provides no useful information. Using a regular progress bar would:

  • Give the user an idea of how much of the replay has been processed
  • Give the user an estimation of how long it will take to convert the replay (which is handled automatically by the progressbar module)

Considering that rendering MP4s can take a while, it would be nice to provide this information to users so they're not left in the dark.
@xshill xshill added the enhancement New feature or request label Jan 4, 2021
@xshill xshill self-assigned this Jan 4, 2021
xshill pushed a commit that referenced this issue Jan 5, 2021
Update changelog after issue #274
141488c
@xshill xshill mentioned this issue Jan 5, 2021
Merged
@xshill xshill closed this as completed in 1087125 Jan 6, 2021
xshill added a commit that referenced this issue Jan 6, 2021
@xshill
Merge pull request #275 from GoSecure/mp4-progress
29118c0 
Use proper progress bar for MP4 conversion. Fixes #274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xshill xshill

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xshill