Pip packaging #5
Conversation
For example: * Config files in ~/.config/malboxes/ * Temporary cache files in ~/.cache/malboxes/
* malboxes provides new variables to profiles for cache_dir * Path fixes in all supported packer profiles
| Ex: ./malboxes registry win10_64_analyst add HKCU:\Software Malboxes IsAwesome String | ||
| Example: | ||
|
|
||
| malboxes registry win10_64_analyst add HKCU:\Software "Malboxes IsAwesome" String |
There was a problem hiding this comment.
I'm pretty sure that this isn't the same thing. The first modifies HKCU:\Sofware's Malboxes key with the value IsAwesome as a String. I'm not sure about the behaviour of the second one since we do not provide a value for the "Malboxes IsAwesome" key.
There was a problem hiding this comment.
|
Worked from pip git install method. Trying Windows tomorrow. |
|
|
||
| == Installation | ||
|
|
||
| sudo pip install git+https://github.com/GoSecure/malboxes.git@pip-packaging#egg=malboxes |
There was a problem hiding this comment.
Have you tried that with a machine that didn't have the dependencies ? It doesn't work for me and the traceback indicates that it cannot import appdirs (so that should be the same for all our dependencies) because __version__ is imported from __init__.py which tries to import the dependencies. I got the same from my server too. Also, if we are py3, shouldn't that be pip3 since pip defaults to pip2 in lots of distros (pip --version points to py2.7 for both of the machines I tested on) ? Official docs doesn't seem to discourage hardcoding the version so couldn't we do that ? Django does something interesting that doesn't involve hardcoding so that would be an option too.
There was a problem hiding this comment.
Good point for pip3! I use arch so pip is a symlink to pip3 but you are right about most distro being pip -> pip2.
|
After I manually installed appdirs, everything worked fine so I would fix that and merge ! |
setup.py needed to be able to import the main mailboxes package which pulled in all dependencies unconditionally resulting in an error if you were missing one. Version is now in it's own file without dependencies
On Windows settings are stored under malboxes\\malboxes and so recursive creation was required on that platform.
|
I've tried it on windows and it works on |
|
Tested Windows with git installed from an installer and it works in |
Commit trail says it all.
I tested (and fixed) Win 10 x86 and it worked.
Unfortunately due to
shutil.which()we are Python 3.3+ now. This shouldn't be a problem for most environments though.I used the devel install way (see docs/). Tomorrow I'll test:
But meanwhile, @Svieg can you give it a review please?