Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch coverage support #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rodrigo-speller
Copy link

Changes proposed in this pull request:

  • Set CoverageResult.Batches as public. This allow generate other reports using SQLCover as library.
  • Refactory of CoverageResult.OpenCoverXml to use an serializer (OpenCoverXmlSerializer). Use it to SRP and for most readable code.
  • Branch coverage support!!!

How to test this code:

  • Create procedures with While and If blocks and generate the OpenCover report.

Has been tested on (remove any that don't apply):

  • SQL Server 2017

@lastlink
Copy link
Contributor

I would add unit tests or make sure this builds, github actions now works w/ integrated db tests, see .github/ .yml file

If you look at the yml I use the dotnet tool reportgenerator to generate teh OpenCover html reports using the existing .xml. If this still works after your change it might be fine then.

also you need to update to handle the pr recently that moved things to a share library using the dotnet standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants