app.js is untestable

[christian-hawk]

The server is always automatically started when:

const app = require('../server/app)

or

const app = rewire('../server/app.js)

For waiting the app to start, this event does the trick:

gluu-passport/server/app.js

Line 87 in 6275ef2

app.emit('appStarted') // event emitter for tests

But for unit-tests, we need to be able to test the app.js file without server starting.

The problem is that, right now,

• the app sever is started inside the recreateHttpServer function
• that's called by reconfigure function,
• that's called by [poolConfiguration function](

  gluu-passport/server/app.js

  Line 92 in 6275ef2

  function reconfigure (cfg) {

  ), that's actually a loop,
• that's called by init function.

Maybe we can use Factory design pattern to detach? Any thoughts @kdhttps @jgomer2001 ?