feat: experiment move commingle_ok into mrp.bom #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t under 12.0. We discarded this for many reasons, however its causing issues. This commit is incomplete R&D [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much closer to how we previously did it under 12.0 (what we know as
mrp_phantom_equiv).When porting that module from 12.0 we hit issues with changes to
explode(), this combined with other issues from adding a custom BoM type, we migrated the functionality out ofmrp.bomintoproduct.commingleand family.However, by product_commingle being separate we're now having issues with tracking all quantities from the sale order, etc.
This is incomplete R&D work with the goal see what happens if we drop product_commingle and family, and effectively find a better way to migrate
mrp_phantom_equiv(equivalents/commingled products as a BoM type), and then add a custom mechanism to track relationships between the original bom and the final exploded line (as we did under 12.0 in the poorly named companion modulemrp_proportional_delivery, which would be leveraged to fix the problems with adding/removing quantities from a sale.order (i.e. if you add a commingled item or a kit which contains a commingled item, and that commingled item explodes into 2 lines, you need to count both lines together, which Odoo will not do. This problem is amplified with heavily nested kits).