Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(blog): create blog part #284

Merged
merged 7 commits into from
Jun 23, 2024
Merged

✨ feat(blog): create blog part #284

merged 7 commits into from
Jun 23, 2024

Conversation

bingling-sama
Copy link
Contributor

@bingling-sama bingling-sama commented Jun 22, 2024 •
edited
Loading

Create blog part for publishing blog posts, still WIP.

  • Basic Post List
  • CSS Style
  • add to nav bar
  • add contributing guide
  • auto close sidebar (help needed)
  • Something else...

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for crashmc ready!

Name Link
🔨 Latest commit 406d811
🔍 Latest deploy log https://app.netlify.com/sites/crashmc/deploys/6677c83d5dffeb00083ea812
😎 Deploy Preview https://deploy-preview-284--crashmc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bingling-sama bingling-sama self-assigned this Jun 22, 2024
@Big-Cake-jpg
Copy link
Contributor

目前看来还行，但是文章列表能不能做成卡片样式并且添加一个封面支持？比如做成类似 Files App 文档 里博客版块那样。
感觉现在只有一个标题有些过于简陋了

@bingling-sama
Copy link
Contributor Author

做了一点点简陋的样式，等待完善，不过已经可以进入 Review 阶段了。

@bingling-sama bingling-sama marked this pull request as ready for review June 22, 2024 16:26
@bingling-sama
Copy link
Contributor Author

改进了一下卡片样式，各位可以点击 Preview Link 看看效果，如果可以的话我就再检查一下其他细节开始最终 Review 了。

PS：卡片的长宽设置急需一些建议。

zyxkad
zyxkad requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@zyxkad zyxkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://deploy-preview-284--crashmc.netlify.app/blog/
Screenshot 2024-06-23 at 00 19 50
这个anchor有🤏问题

@bingling-sama
Copy link
Contributor Author

https://deploy-preview-284--crashmc.netlify.app/blog/ Screenshot 2024-06-23 at 00 19 50 这个anchor有🤏问题

不太懂怎么禁用，他是 Vitepress 弄上去的。因为 Excerpt 是直接用的 Vitepress 的接口，用 v-html 渲染的，所以会带上 Vitepress 的样式

@bingling-sama
Copy link
Contributor Author

2024-06-23.14-29-35.mp4

加了个 scale(0.8)，看着海星？

@zyxkad
Copy link
Member

zyxkad commented Jun 23, 2024 •
edited
Loading

另外建议加一个padding-top，多余的字可以用text-overflow: ellipses样式省略掉

@bingling-sama
Copy link
Contributor Author

另外建议加一个padding-top，多余的字可以用text-overflow: ellipses样式省略掉

要加 padding-top 是指？

@zyxkad
Copy link
Member

zyxkad commented Jun 23, 2024

另外建议加一个padding-top，多余的字可以用text-overflow: ellipses样式省略掉

要加 padding-top 是指？

虽然scale这个操作很难评，但是它确实同时解决了标题太靠近边框的问题

@bingling-sama
Copy link
Contributor Author

另外建议加一个padding-top，多余的字可以用text-overflow: ellipses样式省略掉

要加 padding-top 是指？

虽然scale这个操作很难评，但是它确实同时解决了标题太靠近边框的问题

毕竟 excerpt 展示的是渲染后的 markdown 内容，也不太方便把里面的样式全部重写。scale的话……能用就行（x

@bingling-sama
Copy link
Contributor Author

我发现那段文字不是溢出了，是被 Vitepress 给截断了：
image

@bingling-sama bingling-sama merged commit 080c31e into dev Jun 23, 2024
4 checks passed
@bingling-sama bingling-sama deleted the blog branch June 23, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyxkad zyxkad zyxkad approved these changes

@Big-Cake-jpg Big-Cake-jpg Big-Cake-jpg approved these changes

@bingxin666 bingxin666 bingxin666 approved these changes

@HRxiaohu HRxiaohu Awaiting requested review from HRxiaohu

@FalfaChino FalfaChino Awaiting requested review from FalfaChino

Assignees

@bingling-sama bingling-sama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bingling-sama @Big-Cake-jpg @zyxkad @bingxin666