Issue#630 admin featured content #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikre
suggested changes
Jul 31, 2019
| </div> | ||
| </Card> | ||
| } | ||
| i={featuredContentList.length} |
There was a problem hiding this comment.
Trenger vel ikke i her hvis det er featuredContentList.length og du sender inn featuredContentList som en prop? :)
There was a problem hiding this comment.
Dersom man redigerer en av de allerede eksisterende elementene bruker jeg i til å identifisere hvilke av elementene i listen jeg redigerer. Dersom man legger til et nytt element vil i være lik lengden til listen, men i andre tilfeller vil den avhenge av hvilket nummer i listen elementet er.
| import type { FeaturedContent } from '../../types'; | ||
|
|
||
| type Props = { | ||
| i: number, |
There was a problem hiding this comment.
i kan du få fra featuredContentList.length så droppe den som prop (se kommentaren over :) )
kievu
force-pushed
the
Issue#630-admin-featuredContent
branch
from
00f1b16 to
229cf0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/GlobalDigitalLibraryio/issues/issues/630