Bugfix flight time through midnight utc #53
Conversation
- Deprecate function add_times - Deprecate function add_seconds
… into bugfix-flight-time-through-midnight-utc # Conflicts: # opensoar/task/aat.py # opensoar/task/race_task.py # opensoar/utilities/helper_functions.py # tests/utilities/test_helper_functions.py
|
Nice step, good idea also to hit two birds with one stone in this MR (timezone aware datetimes + de-duplication)! did not yet look at the tests |
Have updated the branch and fixed mosts of the tests. Could you check what's going wrong with the remaining two tests? Code is very nested and hard to figure out what's happening exactly |
|
aerofiles v1.4.0 released with the needed changes: https://github.com/Turbo87/aerofiles/releases/tag/v1.4.0 Let me know, if there are any problems. |
|
Thanks @bubeck, now back from holiday we will start changing it here |
| @@ -357,6 +356,7 @@ def _get_waypoint_fixes(self, outlanded, sector_fixes, outside_sector_fixes=None | |||
| if outside_sector_fixes is None: | |||
| outside_sector_fixes = list() | |||
|
|
|||
| # this doesnt work due to latest aerofiles version | |||
There was a problem hiding this comment.
this still needs to be addressed
| aerofiles==1.4.0 | ||
| beautifulsoup4==4.12.3 | ||
| geojson==3.1.0 | ||
| shapely==2.0.6 |
There was a problem hiding this comment.
decide what to do with this. fixing them completely might be too strict. this is a library that is used by others. they need some freedom to use other versions
| @@ -1,6 +1,12 @@ | |||
| OpenSoar | |||
There was a problem hiding this comment.
(not related to this line)
If all looks good, do final check with Pysoar on some comps
| @@ -1,6 +1,12 @@ | |||
| OpenSoar | |||
There was a problem hiding this comment.
(not related to this line)
Determine new version number (backwards incompatible maybe?) and write changelog
Written with the idea to put the date in the igc file. Can imagine you have some ideas about this implementation. Have not invested effort yet to fix tests etc. Curious what your thoughts are