Adding CI for hydra #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Added clippy commit as well |
Switch amman to solana-local-validator Testing setup Switch back to amman Anchor build Add more logs Add more logs Switch back to anchor Rename keypair Anchor provider fix Add logs back Fix keypair name Test reporter Debug test reporter Revert name change Bump solana version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 4 commits numbered below. Example of the CI checks can be seen here solana-nft-programs#3
1.1 Test workflow that does
I tried using amman in the workflows setup but it doesnt work because of the dependency on local mpl, I looked into using the amman clone feature but it also doesnt work in CI and solana-local-validator works fine in CI
The test suit uses test reporter to report back to the active PR
Anchor rename: I had to rename the lib from
hydratohydra_walletso that anchor deploy works into the local validator. I could get around this but I think its correct to name the lib the same as the name anyways. Presumably you had to change the name because of crates collisionSoteria unsafe math operations - this commit addresses issues found in soteria. They are not really issues but its prudent to use checked math operations
Rust fmt - juts ran rust fmt to format the program
Rust clippy checks
Clippy is a decently large commit but it should be non-functional changes only clippy warnings fixes