fix: clarify lazy API in bindings #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talagluck
reviewed
Aug 5, 2024
Comment on lines
+8
to
+9
| with pytest.raises(Exception): | ||
| con.sql("select count(*) from tblsqlhelper;") |
There was a problem hiding this comment.
Why does this raise an error?
Comment on lines
+17
to
+18
| with pytest.raises(Exception): | ||
| con.sql("create table tblsqlhelper (a int, b int);") |
There was a problem hiding this comment.
I understand why this raises, but not why the selects would.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion we had yesterday, this is more clear than "we have
this API that's lazy and you can rexecute it, unless your statement
has side effects..." which is the other way to avoid confusion and
errors, it seems.