Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UX when pgsrv fails to proxy #249

Closed
scsmithr opened this issue Oct 28, 2022 · 1 comment · Fixed by #258
Closed

Better UX when pgsrv fails to proxy #249

scsmithr opened this issue Oct 28, 2022 · 1 comment · Fixed by #258
Assignees
@scsmithr

Comments

@scsmithr
Copy link
Member

When specifying an incorrect database name:

~ $ psql postgresql://glaredb:[email protected]:6543/glaredb?options=--name%3Ddoes-not-exist
psql: error: connection to server at "proxy.glaredb.com" (34.132.144.12), port 6543 failed: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

We should be sending back an appropriate error response to the connection.

Related: #217
@scsmithr scsmithr added the bug label Oct 28, 2022
@scsmithr
Copy link
Member Author

We should also be checking the status of the response before trying to decode. If it's not 200, then it's an error response and we should display that error to the user.

@scsmithr scsmithr self-assigned this Oct 31, 2022
@scsmithr scsmithr mentioned this issue Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scsmithr scsmithr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Return auth errors to client connection GlareDB/glaredb
1 participant
@scsmithr