Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit error handling in pgsrv #217

Closed
Tracked by #366
scsmithr opened this issue Oct 20, 2022 · 2 comments
Closed
Tracked by #366

Revisit error handling in pgsrv #217

scsmithr opened this issue Oct 20, 2022 · 2 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@scsmithr
Copy link
Member

For some errors, we propagate up to the server which will then kill the connection. We need to make sure that we limit the kinds of errors that we propagate to avoid disconnecting the client prematurely (e.g. failing to parse a query should not cause a disconnect).

@greyscaled
Copy link
Contributor

Someone just needs to sit down and comb through the handshake and understand each error.

Sometimes you want to close a connection, but others you want to send over the connection to the client and continue.

No amount of grooming should be done, it's just work of going line by line through the code.

@scsmithr scsmithr self-assigned this Jan 3, 2023
@scsmithr
Copy link
Member Author

scsmithr commented Jan 6, 2023

I'm going to mark this as done. #449 helped in this area, and as far as I can tell, we're sending errors to the client when appropriate.

If there's a case where we don't send back the appropriate error, or if the connection closes when it shouldn't, an issue should be opened up for that specific case.

@scsmithr scsmithr closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants