Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Improve logging and async debugging experience #108

Closed
justinrubek opened this issue Sep 16, 2022 · 1 comment
Closed

logging: Improve logging and async debugging experience #108

justinrubek opened this issue Sep 16, 2022 · 1 comment
Labels
chore DX, infra etc that's not build or CI related

Comments

@justinrubek
Copy link
Contributor

We are currently using the tracing crate for logging, but there is potential for adding on to this for development. Especially as the application gets more complex and uses increasing amounts of async code this is becoming more difficult. When working on #63 it felt like there were major slowdowns at times because of this. I decided to learn more about the tracing library and immediately they offer a few suggestions:

I do not have experience with any of these, but they look like they could be very useful and we could probably pick them up fairly simply. Integrating these tools, learning how to use them, writing a quick-guide, and making a pass on tracing could help significantly

@justinrubek justinrubek added this to the Project maintenance milestone Sep 16, 2022
@justinrubek justinrubek self-assigned this Sep 27, 2022
@justinrubek
Copy link
Contributor Author

Linked branch tokio-console. It's a fairly simple change but it seems that the console is limited. I can't find a way to look at the logs or see much of anything that would be used for basic debugging. There is some information to be had there so it's not entirely useless but it certainly is not what I'd expected.

It looks like the opentelemetry route may have promise. This needs some more setup and will have to be explored further. Since enabling tokio-console required configuring tokio_unstable I do not intend to open it in a PR at this time.

In the meantime, if you want to try out the console everything should be available in the nix devshell. The console subscriber is configured in the logutil crate so it is already wired into the server: cargo run --bin glaredb -- -v server and tokio-console

@scsmithr scsmithr removed this from the Project maintenance milestone Nov 20, 2022
@scsmithr scsmithr added the chore DX, infra etc that's not build or CI related label Nov 20, 2022
@greyscaled greyscaled closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
scsmithr added a commit that referenced this issue Nov 20, 2024
* stub list

* stub list functions

* impl

* variadic

* if you don't run the tests, is your logic really wrong?

* write a test

* list extract

* variadic cast

* syntactic sugar

* lint

* another test

* remove outdated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore DX, infra etc that's not build or CI related
Projects
None yet
Development

No branches or pull requests

3 participants