Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Extended query protocol #101

Closed
6 of 14 tasks
scsmithr opened this issue Sep 15, 2022 · 4 comments
Closed
6 of 14 tasks

[Epic] Extended query protocol #101

scsmithr opened this issue Sep 15, 2022 · 4 comments
Labels
feat New feature or request

Comments

@scsmithr
Copy link
Member

scsmithr commented Sep 15, 2022

https://www.postgresql.org/docs/current/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY

benchbase

Benchbase uses prepared statements, so attempting to get the tpch benchmark running would probably be a good test case.

$ git clone --depth 1 https://github.com/glaredb/benchbase.git
$ cd benchbase
$ git checkout glaredb
$ ./mvnw clean package -P postgres
$ cd target
$ tar xvzf benchbase-postgres.tgz
$ cd benchbase-postgres
$ java -jar benchbase.jar -b tpch -c config/glaredb/sample_tpch_config.xml --create=true --load=true --execute=true

features

scsmithr added a commit that referenced this issue Sep 15, 2022
Sends parameter status messages when starting up a new connection.

Currently only sends `server_version`. This was enough to get pgJDBC to startup
properly. This was an attempt to try to get
benchbase (https://github.com/GlareDB/benchbase/tree/glaredb) running against a
glaredb server.

I have not gotten benchbase to successfully run a benchmark, see
#101.
scsmithr added a commit that referenced this issue Sep 16, 2022
* feat: Implement parameter status message for pgsrv

Sends parameter status messages when starting up a new connection.

Currently only sends `server_version`. This was enough to get pgJDBC to startup
properly. This was an attempt to try to get
benchbase (https://github.com/GlareDB/benchbase/tree/glaredb) running against a
glaredb server.

I have not gotten benchbase to successfully run a benchmark, see
#101.

* Include both byte and char reps in error string
@RustomMS RustomMS added the epic label Oct 7, 2022
@scsmithr scsmithr added feat New feature or request and removed enhancement labels Nov 20, 2022
@scsmithr scsmithr assigned scsmithr and unassigned justinrubek Nov 28, 2022
@scsmithr scsmithr removed their assignment Dec 5, 2022
@greyscaled greyscaled changed the title pgsrv: Implement extended query protocol [Epic] Extended query protocol Dec 12, 2022
@greyscaled
Copy link
Contributor

This epic needs re-work and break-out. We don't need everything from the extended query protocol, but there are use-cases where someone will need to run a prepared query.

@greyscaled
Copy link
Contributor

Lower until we get to a certain milestone in product of supporting analytical use cases.

@greyscaled
Copy link
Contributor

We have stories for the prepared statements. Other than those, does an analytics db (non-transactional) need to implement more from the extended query protocol?

I know we have a long-term vision of HTAP, but if it's far enough away from our immediate use case, I'd rather close the ticket since it's stale and re-open an epic for that when we're working towards that goal more actively.

@greyscaled
Copy link
Contributor

Stale - can reopen later

@greyscaled greyscaled closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants