Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #623 - Add LCA001 Hue color lamp model #624

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

hotfix31
Copy link
Contributor

@hotfix31 hotfix31 commented Dec 4, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Just adding LCA001 Hue color lamp model on Hue service lamp mapping

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         404      404           
  Lines        4936     4936           
=======================================
  Hits         4536     4536           
  Misses        400      400
Flag Coverage Δ
#server 91.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../services/philips-hue/lib/light/light.getLights.js 97.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da9fc1e...7bd8580. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 0afc6c1 into GladysAssistant:master Dec 9, 2019
@hotfix31 hotfix31 deleted the add-hue-device branch December 10, 2019 22:19
@hotfix31 hotfix31 restored the add-hue-device branch December 10, 2019 22:20
@hotfix31 hotfix31 deleted the add-hue-device branch December 10, 2019 22:20
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants