-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes: zWave device integration and BinaryDeviceFeature component #608
Merged
Pierre-Gilles
merged 4 commits into
GladysAssistant:master
from
sescandell:pr-zwaveFixes
Nov 20, 2019
Merged
Some fixes: zWave device integration and BinaryDeviceFeature component #608
Pierre-Gilles
merged 4 commits into
GladysAssistant:master
from
sescandell:pr-zwaveFixes
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sescandell
force-pushed
the
pr-zwaveFixes
branch
from
November 14, 2019 23:43
235c816
to
9df3f03
Compare
… not be authorized.
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 91.92% 91.83% -0.09%
==========================================
Files 399 400 +1
Lines 4865 4876 +11
==========================================
+ Hits 4472 4478 +6
- Misses 393 398 +5
Continue to review full report at Codecov.
|
Thanks for this great PR, tested on merged! 👍 👏 |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…onent and Gateway (GladysAssistant#608) * Various changes: zWave device integration and BinaryDeviceFeature component fixes * Add test * Fix tests... actually Mock were broken: using spy on prototype should not be authorized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR initially was intended to fix the Device.setValue call for zWave devices. But, making tests with a real BinarySwitch device I identified another issue with the BinarySwitch front component and the Gateway forwarder.
Changes: