Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy NumPy random number generator #511

Merged
merged 16 commits into from
May 10, 2024

Conversation

rhugonnet
Copy link
Member

@rhugonnet rhugonnet commented Apr 27, 2024

This PR converts all legacy calls np.random.seed(seed=) into np.random.default_rng(seed=).
It also removes the random_state_definition function that was essentially useless (np.random.default_rng() also accepts None, int or another np.random.Generator and returns the right result).

We stop the support for np.random.RandomState as input, which only provided access to specific legacy generator seeds, so was essentially useless for our applications here (we're already satisfied passing an integer as seed, or a specific random generator from np.random.Generator, we don't need any kind of repeatability with old-schools generators).
And renames rnd into rng everywhere for consistency.

Resolves #510

@rhugonnet
Copy link
Member Author

Requires a new release of GeoUtils to have a consistent subsampling output. On the way...

@rhugonnet rhugonnet merged commit 2c9f2b3 into GlacioHack:main May 10, 2024
13 checks passed
@rhugonnet rhugonnet deleted the remove_np_legacy_rng branch May 10, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy NumPy random number generator
1 participant