-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy NumPy random number generator #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a new release of GeoUtils to have a consistent subsampling output. On the way... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all legacy calls
np.random.seed(seed=)
intonp.random.default_rng(seed=)
.It also removes the
random_state_definition
function that was essentially useless (np.random.default_rng()
also accepts None, int or anothernp.random.Generator
and returns the right result).We stop the support for
np.random.RandomState
as input, which only provided access to specific legacy generator seeds, so was essentially useless for our applications here (we're already satisfied passing an integer as seed, or a specific random generator fromnp.random.Generator
, we don't need any kind of repeatability with old-schools generators).And renames
rnd
intorng
everywhere for consistency.Resolves #510