Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert coregistration results to 4x4 transformation matrices #67

Closed
erikmannerfelt opened this issue Mar 22, 2021 · 1 comment · Fixed by #71
Closed

Convert coregistration results to 4x4 transformation matrices #67

erikmannerfelt opened this issue Mar 22, 2021 · 1 comment · Fixed by #71
Assignees
Labels
enhancement Feature improvement or request

Comments

@erikmannerfelt
Copy link
Contributor

@adehecq and I have discussed at multiple points in time that this would be a nice addition. For example, if one would want to use the results of the coregistration in another tool (ASP / Metashape etc.), 4x4 transformation matrices are the way to go.

For bias corrections, it would be as simple as:

[
    [1, 0, 0, 0],
    [0, 1, 0, 0],
    [0, 0, 1, bias],
    [0, 0, 0, 1]
]

for translations:

[
    [1, 0, 0, xcorr],
    [0, 1, 0, ycorr],
    [0, 0, 1, bias],
    [0, 0, 0, 1]
]

We also discussed that 1st degree deramps can be described as a bias, rotation and scale in the horizontal direction. 2nd degree and higher deramps are however impossible to describe as a 4x4 matrix, and could return a NotImplementedError or similar.

PDAL and opencv already provide matrices from their ICP approaches, so this would be simple to return as a np.ndarray.

This could be part of the coreg.py revision initiative (#24).

@rhugonnet
Copy link
Member

👍

@erikmannerfelt erikmannerfelt linked a pull request Apr 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants