Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get a transformation matrix betwen two PCs #58

Closed
adehecq opened this issue Mar 19, 2021 · 2 comments
Closed

Add function to get a transformation matrix betwen two PCs #58

adehecq opened this issue Mar 19, 2021 · 2 comments
Labels
enhancement Feature improvement or request new-feature A new functionality / feature or request

Comments

@adehecq
Copy link
Member

adehecq commented Mar 19, 2021

For now, deramping and nuth_kaab algorithm do not return a transformation matrix. Returning a trasnformation matrix would make it easier to:

  • chain with other approaches like ICP, by simply multiplying the two transformations
  • update the associated cameras
  • save the applied transformation and possibly apply it to other PC/DEMs

So far, the best solution I found is this library: https://github.com/jewettaij/superpose3d
There is a lot of unused code there, so it could be worth just rewriting some of the code.

@adehecq adehecq added the enhancement Feature improvement or request label Mar 19, 2021
@erikmannerfelt
Copy link
Contributor

Oops, I kind of duplicated this suggestion in #67.

I suggest to keep them both, however, as this issue also touches on transforming external data such as camera positions, and my issue includes some pointers toward implementing it.

@erikmannerfelt
Copy link
Contributor

This was implemented in #71 .

@erikmannerfelt erikmannerfelt added the new-feature A new functionality / feature or request label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request new-feature A new functionality / feature or request
Projects
None yet
Development

No branches or pull requests

2 participants