Fix network modal issue

[HrithikSampson]

Summary by CodeRabbit

• New Features

  • Improved modal management for network donation errors, enhancing user experience when switching networks.

• Bug Fixes

  • Streamlined modal closing logic to ensure it responds correctly when users change to an accepted network.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 10:13am

[coderabbitai]

Walkthrough

The changes in the DonateWrongNetwork.tsx component focus on optimizing the modal closing logic by introducing the useCallback hook for the closeNetworkModal function. This function centralizes the logic for setting the donate modal priority and closing the modal. Additionally, the component now imports DonateModalPriorityValues and useDonateData from the donate.context, enhancing the management of modal states based on the current network ID.

Changes

File	Change Summary
src/components/modals/DonateWrongNetwork.tsx	- Added closeNetworkModal using useCallback to optimize modal closing logic. - Imported DonateModalPriorityValues and useDonateData for managing modal states. - Updated useEffect to invoke closeNetworkModal() based on network ID checks.

Possibly related PRs

• fix: network modal showing while the page is loading #4711: The changes in this PR involve updates to the DonateModalPriorityValues and the setDonateModalByPriority function, which are also referenced in the main PR's modifications to the DonateWrongNetwork.tsx component, indicating a direct connection in managing modal states.

Suggested reviewers

• aminlatifi
• RamRamez
• mohammadranjbarz

Poem

🐰 In the modal's dance, a change so bright,
With useCallback in the spotlight.
Close the network, set it right,
A hop, a skip, all feels just right!
Donate with joy, in the moon's soft light. 🌙

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/components/modals/DonateWrongNetwork.tsx (1)

65-68: LGTM with a minor suggestion: Consider updating useCallback dependencies.

The closeNetworkModal function is well-implemented using useCallback for optimization. It correctly centralizes the modal closing logic.

However, consider adding setDonateModalByPriority and closeModal to the dependency array of useCallback to ensure the function is updated if these dependencies change:

const closeNetworkModal = useCallback(() => {
  setDonateModalByPriority(DonateModalPriorityValues.None);
  closeModal();
}, [setDonateModalByPriority, closeModal]);

This change ensures that the callback is updated if either setDonateModalByPriority or closeModal changes, which is unlikely but possible in complex scenarios.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 76f1130 and cfd786f.

📒 Files selected for processing (1)

• src/components/modals/DonateWrongNetwork.tsx (4 hunks)

🔇 Additional comments (3)

src/components/modals/DonateWrongNetwork.tsx (3)

1-1: LGTM: New imports added correctly.

The new imports for DonateModalPriorityValues and useDonateData from the donate context are appropriate for the component's functionality.

Also applies to: 33-36

---

64-64: LGTM: Correct usage of useDonateData hook.

The setDonateModalByPriority function is correctly extracted from the useDonateData hook, which is appropriate for managing donate modal states in this component.

---

96-96: LGTM: Appropriate use of closeNetworkModal.

The replacement of closeModal() with closeNetworkModal() in the useEffect hook is correct. This change ensures that both the donate modal priority is set and the modal is closed when the network conditions are met.

[MohammadPCh]

Thanks @HrithikSampson