Don't Merge Only for testing issue 4449

[HrithikSampson]

relates to #4449

This pull request is only to create a live preview link to test whether the OFAC sanction modal is appearing on navigating to donate Page.

Summary by CodeRabbit

• New Features

  • Introduced a sanction check for donations, providing users with feedback if their wallet is sanctioned.
  • Added a new modal to inform users about their sanction status before proceeding with donations.

• Bug Fixes

  • Streamlined the donation validation process to improve efficiency and clarity.

• Refactor

  • Simplified error handling in the donation process by consolidating checks and removing unnecessary logic.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 20, 2024 0:29am

[coderabbitai]

Warning

Rate limit exceeded

@HrithikSampson has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 12 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 5af5f63 and f585529.

Walkthrough

The recent changes enhance the donation process by streamlining wallet validation in the DonateModal component and introducing a new sanction check in the OneTimeDonationCard. The validation logic is simplified by removing unnecessary checks, improving clarity, while a new state variable tracks wallet sanction status, providing user feedback through a modal. However, the isWalletSanctioned function now incorrectly returns a hardcoded value, potentially undermining the intended validation functionality.

Changes

Files	Change Summary
src/components/views/donate/OnTime/DonateModal.tsx, src/components/views/donate/OnTime/OneTimeDonationCard.tsx	Simplified wallet validation logic and added a sanction check that updates user interface feedback.
src/services/donation.ts	Modified isWalletSanctioned function to always return true, disregarding actual sanction status.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OneTimeDonationCard
    participant DonateModal
    participant Service

    User->>OneTimeDonationCard: Initiate Donation
    OneTimeDonationCard->>Service: validateSanctions()
    Service-->>OneTimeDonationCard: Sanction Status
    OneTimeDonationCard->>User: Show SanctionModal if Sanctioned
    User->>DonateModal: Proceed to Donate
    DonateModal->>Service: validateTokenThenDonate()
    Service-->>DonateModal: Validate Token
    DonateModal->>User: Donation Confirmation

Loading

Poem

🐰 In fields so green, a rabbit hops,
With code anew, the old way stops.
Sanctions checked, donations bright,
A happy dance in the moonlight! 🌙
With every click, the journey flows,
For joyful hearts, the donation grows! 💖

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Hardcoded return value in isWalletSanctioned.

The function now always returns true, indicating that every wallet is sanctioned. This change is suitable for testing purposes but should be reverted before merging to ensure correct functionality.

-		return true;
+		return result?.isSanctioned || false;

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	return true;
	return result?.isSanctioned || false;