make modifications for transferAllocation function #41
Conversation
|
@jainkrati - this one needs a review to unblock me |
|
Also can we make the Slither Analysis pass before we merge? |
There was a problem hiding this comment.
Thanks @divine-comedian
Looks good, just a simple small change suggested
Reverted the name to the same TokenDistro
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
|
|
|||
| pragma solidity =0.8.10; | |||
| pragma solidity ^0.8.10; | |||
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
|
@divine-comedian @jainkrati I did move the changes under the same contract name TokenDistro, since it's not trivial to change the contract name in the upgrade process. |
|
Thanks @divine-comedian for fixing the slither action, I just did a little change to make it work. |
|
@aminlatifi thanks! I reviewed this one, can you approve it then? |
Approved |
change logic of cancelAllocation to add allocation balance instead of overwriting it.