-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make modifications for transferAllocation function #41
Conversation
@jainkrati - this one needs a review to unblock me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls dm me once comments are resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. just 1 comment
Also can we make the Slither Analysis pass before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @divine-comedian
Looks good, just a simple small change suggested
Reverted the name to the same TokenDistro
@@ -1,6 +1,6 @@ | |||
// SPDX-License-Identifier: GPL-3.0 | |||
|
|||
pragma solidity =0.8.10; | |||
pragma solidity ^0.8.10; |
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
- VerbatimInvalidDeduplication
- FullInlinerNonExpressionSplitArgumentEvaluationOrder
- MissingSideEffectsOnSelectorAccess
- AbiReencodingHeadOverflowWithStaticArrayCleanup
- DirtyBytesArrayToStorage
- DataLocationChangeInInternalOverride
- NestedCalldataArrayAbiReencodingSizeValidation.
It is used by:
- ^0.8.10
@divine-comedian @jainkrati I did move the changes under the same contract name TokenDistro, since it's not trivial to change the contract name in the upgrade process. |
Thanks @divine-comedian for fixing the slither action, I just did a little change to make it work. |
@aminlatifi thanks! I reviewed this one, can you approve it then? |
Approved |
change logic of cancelAllocation to add allocation balance instead of overwriting it.