Add missing semicolons #1546
Merged
Add missing semicolons #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically apply it with clippy: ``` cargo clippy --fix --all-targets --workspace -- -A clippy::all -W clippy::semicolon-if-nothing-returned ```
64 tasks
Byron
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Thanks a lot for picking this up!
I wonder if this check could be added to the standard lints then? These days configuration for Clippy can very well be placed in the top-level Cargo.toml, but I never got around to actually do it.
Any help in that regard is also very much appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically apply it with clippy:
This would close the biggest pedantic clippy complaint in #874