Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output caching headers on RSC/prefetch responses #2559

Merged
merged 12 commits into from
Oct 26, 2024
Merged

Conversation

SamyPesse
Copy link
Member

@SamyPesse SamyPesse commented Oct 25, 2024

This PR ensures all caching headers are also sent in the response when handling prefetch and RSC requests.

Because of cloudflare/next-on-pages#897, I had to use a hack with a custom entrypoint to capture response headers.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 71275ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 25, 2024

GitBook Preview
Latest commit: https://8e240c7d.gitbook-open.pages.dev
PR: https://pr2559.gitbook-open.pages.dev

Copy link

argos-ci bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 8 changed Oct 26, 2024, 8:26 AM

@SamyPesse SamyPesse changed the title Optimize caching Output caching headers on RSC/prefetch responses Oct 26, 2024
@SamyPesse SamyPesse marked this pull request as ready for review October 26, 2024 08:57
@SamyPesse SamyPesse merged commit 4bcbdc5 into main Oct 26, 2024
9 checks passed
@SamyPesse SamyPesse deleted the cache-optim-2 branch October 26, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant