-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add German Locale support #2317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I made a comment but don't trust my German enough to consider that a must :)
I just noticed that I did not import the new locale file inside |
@burghoffdavid Could you please add the translation import in? Thank you! |
@addisonschultz Done ✔️ |
@addisonschultz Not entirely sure why the typecheck CI is failing, any ideas? |
@burghoffdavid yep - I've got to add these types to our backend schema - working on that now 😄 |
1bc0c57
to
d43a183
Compare
Hi @burghoffdavid - first off, I want to apologize for the delays on getting this PR up and live so slowly - it's brought to my attention a lot of workflow improvements we need to make on our end in order to make this a lot more smooth. Secondly, I wanted to let you know that your contribution is now live in GitBook! You can now update the locale to German - let me know if you have any questions! |
Hi, I've added German locale support for GitBook.
Link to Diskussion: https://github.com/orgs/GitbookIO/discussions/537