Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German Locale support #2317

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Add German Locale support #2317

merged 7 commits into from
Jun 13, 2024

Conversation

burghoffdavid
Copy link
Contributor

Hi, I've added German locale support for GitBook.

Link to Diskussion: https://github.com/orgs/GitbookIO/discussions/537

@burghoffdavid
Copy link
Contributor Author

@addisonschultz

@thebiglabasky thebiglabasky self-requested a review May 15, 2024 11:57
Copy link

@thebiglabasky thebiglabasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
I made a comment but don't trust my German enough to consider that a must :)

src/intl/translations/de.ts Outdated Show resolved Hide resolved
@burghoffdavid
Copy link
Contributor Author

I just noticed that I did not import the new locale file inside src/intl/translations/index.ts to add it to the languages var. Should this be added with this PR or will it be added further down the line by the team?

@addisonschultz
Copy link
Contributor

@burghoffdavid Could you please add the translation import in? Thank you!

@burghoffdavid
Copy link
Contributor Author

@addisonschultz Done ✔️

@burghoffdavid
Copy link
Contributor Author

@addisonschultz Not entirely sure why the typecheck CI is failing, any ideas?

@addisonschultz
Copy link
Contributor

@burghoffdavid yep - I've got to add these types to our backend schema - working on that now 😄

@jpreynat jpreynat merged commit 65c7968 into GitbookIO:main Jun 13, 2024
6 of 7 checks passed
@Eloutmanixx Eloutmanixx mentioned this pull request Jun 13, 2024
@addisonschultz
Copy link
Contributor

Hi @burghoffdavid - first off, I want to apologize for the delays on getting this PR up and live so slowly - it's brought to my attention a lot of workflow improvements we need to make on our end in order to make this a lot more smooth.

Secondly, I wanted to let you know that your contribution is now live in GitBook!

Screenshot 2024-06-19 at 19 51 27

You can now update the locale to German - let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants