Fixes version calculation issue introduced when fixing #465 #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow! That AppVeyor build was wicked fast! |
|
Yeah, since the VM upgrades they fly. It's awesome |
JakeGinnivan
added a commit
that referenced
this pull request
Jul 21, 2015
Fixes version calculation issue introduced when fixing #465
|
I knew there had been some improvements, had hadn't actually "witnessed" one. Truly amazing! @FeodorFitsner has a lot to be proud of! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for figuring out conflicting sources was wrong. It was close enough to look right in most scenarios but caused master to calculate with the wrong version after merging a release branch and tagging (did not increment to next patch release).