Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation of Regex to a central location #4246

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Oct 5, 2024

This pull request focuses on updating the TagPrefix to TagPrefixPattern across various files and configurations, and replacing hardcoded regex patterns with constants from RegexPatterns. Additionally, it includes minor code cleanup by removing unused imports. (AI generated)

Moving the creation of the regex to RegexPatterns allows to have a central location that helps cache and reuse, and when the .net60 is dropped, to benefit from the Source Generated Regex (for AOT)

@arturcic arturcic changed the title Feature/regex Move creation of Regex to a central location Oct 5, 2024
@arturcic arturcic added this to the 6.x milestone Oct 5, 2024
@arturcic arturcic merged commit 9f8b337 into GitTools:main Oct 5, 2024
106 checks passed
Copy link
Contributor

mergify bot commented Oct 5, 2024

Thank you @arturcic for your contribution!

@arturcic arturcic deleted the feature/regex branch October 5, 2024 13:36
@arturcic arturcic modified the milestones: 6.x, 6.0.3 Oct 15, 2024
@gittools-bot
Copy link

🎉 This issue has been resolved in version 6.0.3 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants