Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace the version mode mainline part i.a #3844

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Dec 18, 2023

Description

Create TrunkBasedVersionStrategy implementation and replace the version mode Mainline in 6.x.

For more detail please see the following ADR:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-I.A branch from 6c92efb to d1bd8db Compare December 18, 2023 13:16
@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-I.A branch from d1bd8db to 37e3dc1 Compare December 18, 2023 13:22
@HHobeck
Copy link
Contributor Author

HHobeck commented Dec 18, 2023

@arturcic: Here we go the preparation PR

@arturcic
Copy link
Member

@arturcic: Here we go the preparation PR

Thanks, now it will be easier to follow the changes and review.
Sorry for the request, I prefer to have smaller PRs that I can "load" into my mind and "understand" it

@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-I.A branch from 51558de to d4ce0b6 Compare December 18, 2023 14:05
@HHobeck HHobeck force-pushed the feature/Replace-the-version-mode-Mainline-Part-I.A branch from d2fb63a to c8c04f3 Compare December 19, 2023 09:03
@arturcic
Copy link
Member

It will get merged when the build finishes

@arturcic arturcic merged commit eea7c9b into GitTools:main Dec 19, 2023
106 of 108 checks passed
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you @HHobeck for your contribution!

@arturcic arturcic added this to the 6.x milestone Dec 19, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.5 Jan 9, 2024
@arturcic
Copy link
Member

arturcic commented Jan 9, 2024

🎉 This issue has been resolved in version 6.0.0-beta.5 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@scottjohnstone
Copy link

scottjohnstone commented Feb 8, 2024

@arturcic The PR was merged without the two documentation tasks being complete; was this intentional? Reviewing the issue (3601), it's unclear how/when to use VersioningStrategies+DeploymentMode with regards to "mode" in the GitVersion.yml config. https://gitversion.net/docs/reference/modes/
Thanks!

@arturcic
Copy link
Member

arturcic commented Feb 8, 2024

@arturcic The PR was merged without the two documentation tasks being complete; was this intentional? Reviewing the issue (3601), it's unclear how/when to use VersioningStrategies+DeploymentMode with regards to "mode" in the GitVersion.yml config. https://gitversion.net/docs/reference/modes/ Thanks!

We should address the docs by the time we release 6.0. @HHobeck will be working on that.

@arturcic
Copy link
Member

arturcic commented Feb 8, 2024

@scottjohnstone
Copy link

Thanks @arturcic - the bad link for the Chocolately Package was referenced somewhere on github GitTools/GitVersion but I can't find it now. Nonetheless, thanks for the correct link and sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants