Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GitVersion.Core, GitVersion.Schema): improve implementation of Types and JSON keywords in GitVersion.Configuration.json #3749

Merged
merged 16 commits into from
Dec 8, 2023

Commits on Dec 4, 2023

  1. feat(GitVersion.Core, GitVersion.Schema): add support for JSON `defau…

    …lt` annotation in schemas
    
    Only constant values can be passed to attributes, but an attribute's constructor can convert a parameter to the desired Type.
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b558b7b View commit details
    Browse the repository at this point in the history
  2. fix(GitVersion.Configuration): refactor 'JsonPropertyPattern' usage t…

    …o 'JsonPropertyDefault'
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1978e75 View commit details
    Browse the repository at this point in the history
  3. feat(GitVersion.Core, GitVersion.Schema): decouple format annotatio…

    …n from `pattern`
    
    They are not mutually-inclusive. They have different purposes and can be used without the other.
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bce0ab3 View commit details
    Browse the repository at this point in the history
  4. refactor(GitVersion.Configuration): utilize JsonPropertyFormat

    also, update property descriptions and add comments
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    de0377c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e286f91 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9364cb0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63127c3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aa8524e View commit details
    Browse the repository at this point in the history
  9. refactor(GitVersion.Core, GitVersion.Configuration): add const var De…

    …faultLabelNumberPattern
    
    And fix pattern inconsistency. It was failing tests.
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    27d22d4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    82b9a9c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ca54838 View commit details
    Browse the repository at this point in the history
  12. build: fix build.ps1 argument parsing and passing

    Switches should not have values and some keys' values should not be enclosed with double-quotes. Both were leading to fatal errors.
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    89cc83d View commit details
    Browse the repository at this point in the history
  13. refactor(Common): when gitversion.dll not found, throw FileNotFound a…

    …nd recommend running build.ps1 with "build,BuildPrepare"
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    af134dd View commit details
    Browse the repository at this point in the history
  14. refactor(GitVersion.Configuration): add BeforeString to avoid seriali…

    …zing Nullable<DateTimeOffset>
    
    Nullable types seem to ignore the types' built-in JSON converters
    i.e. DateTimeOffset <=> string, but DateTimeOffset? <=> object or null
    BinToss committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    47f2cff View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    9a70b19 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. cleanup

    arturcic committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3dddd7e View commit details
    Browse the repository at this point in the history