Removed setting Language=C# from GitVersion.MsBuild.props #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abatishchev thank you for submitting the PR. Most probably we will merge this one, but we need to check what was the reason to set the property in the first place. |
Resolves GitTools#3654. Rationale: GitVersion should not force C# language for projects that aren't C#, such as F# or generic *.msbuildproject.
abatishchev
force-pushed
the
patch-1
branch
from
f196981
to
8318dd4
Compare
|
Hi @arturcic, When I opened the PR, all checks have succeeded, I believe. But after I rebased in the morning - some tests fail with an unexpected error. Can you please take a look? |
arturcic
approved these changes
Sep 29, 2023
|
Thank you @abatishchev for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed this line:
GitVersion/src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.props
Line 7 in 1db2828
Related Issue
Resolves #3654.
Motivation and Context
GitVersion should not force C# language for projects that aren't C#, such as F# or generic *.msbuildproject.
How Has This Been Tested?
See #3654 and a detailed investigation in dotnet/project-system#9012
Checklist: