Handle int64 numbers when writing version variables

[RatserX]

Description

Long numeric values for certain version variable fields (e.g. PreReleaseNumber) cause the number parsing to fail and throw the InvalidOperationException.
WriteNumberValue supports int64 so this should be a pretty safe update.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[asbjornu]

This seems like something we should release in v5. It also feels like something that should be roll into @james-bjss' #2703 which also deals with integer parsing. Perhaps you can pick up his PR and rebase it against support/5.x, @RatserX?

[RatserX]

This seems like something we should release in v5. It also feels like something that should be roll into @james-bjss' #2703 which also deals with integer parsing. Perhaps you can pick up his PR and rebase it against support/5.x, @RatserX?

I just rebased against support/5.x. I checked that PR but it seems that we're already handling int64 numbers, so we shouldn't run into overflow exceptions in the scenario that PR was fixing. Do we still need to do a TryParse?

[asbjornu]

True, #3028 did most of that but you've found a missed or new occurrence, which is great. I still think there's value in consistently having a TryParse() pattern, but as it's going to fail a lot less with long than int, I think we can merge this and leave #2703 open as a avenue for future improvement.

[mergify]

Thank you @RatserX for your contribution!

[RatserX]

@asbjornu Is there any ETA as to when a new 5.x version is going to be released? This change would actually help us unblock a lot of our projects.

[arturcic]

🎉 This issue has been resolved in version 5.11.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀