-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2592: GitVersion.MsBuild does not set environment variables for GitHub Action #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7c604d6.
This file is deleted anyway together with the test repo.
I will have a look. Honestly I would prefer to keep the |
@arturcic Shall I rename |
Ok, I had a look now, I would agree we need to have different names for AzurePipelines and got GitHubActions, merging |
arturcic
approved these changes
Mar 22, 2021
Thank you @ThomasPiskol for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes code changes and tests to fix #2592.
Description
The actual change in
src/GitVersion.Core/BuildAgents/GitHubActions.cs
is quite small.Most of the code changes are related to the NUnit tests. I've renamed a few methods, e.g.
ExecuteMsBuildTaskInBuildServer
toExecuteMsBuildTaskInAzurePipeline
because they are actually testing the Azure Pipelines integration and not a generic build server integration.Additionally I've added some tests (
WriteVersionInfoTaskShouldUpdateBuildNumberInAzurePipeline
) to reproduce #2552. Right now these tests are ignored.Related Issue
#2592
Motivation and Context
Previously the GitHub Action integration was coupled to the setting
update-build-number
.This behaviour is not consistent with the other build server integrations and also not intended from my point of view.
Adding the GitVersion environment variables does not change the build number and should be always done independently of
update-build-number
.How Has This Been Tested?
Checklist: