Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bamboo.md #2458

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Update bamboo.md #2458

merged 1 commit into from
Nov 17, 2020

Conversation

dejoost
Copy link

@dejoost dejoost commented Nov 17, 2020

changed the sed arguments, the example was deleting the wrong line and the proposed alternative will always delete the last line, regardless of the number of lines in the file

Update bamboo.md
476e1fa 
changed the sed arguments, the example was deleting the wrong line and the proposed alternative will always delete the last line, regardless of the number of lines in the file
asbjornu
asbjornu approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that's much better!

@asbjornu asbjornu merged commit 888bf81 into GitTools:master Nov 17, 2020
@asbjornu
Copy link
Member

Thanks for your contribution, @dejoost! 🙏

@arturcic arturcic added this to the 5.6.0 milestone Dec 19, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 5.6.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dejoost @asbjornu @arturcic