Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow special characters in Assembly InformationalVersion #2341

Closed
wants to merge 2 commits into from

Conversation

LazaroOnline
Copy link
Contributor

@LazaroOnline LazaroOnline commented Jun 24, 2020

Description

Allow any special character in Assembly InformationalVersion.
Added a parameter in the common function "CheckAndFormatString" to control whether or not special chars gets replaced.

New in 2nd commit:

Added a new config parameter: assembly-informational-is-semver that is true by default to make this backwards compatible.
If set to false then it allows any character in assembly-informational-version.

Related Issue

#2339
#2199

Motivation and Context

Allow any special character in Assembly InformationalVersion.
It is the only place we can add free long customized text describing anything we want and readable from dll/exe file properties.

How Has This Been Tested?

Included a test.
Run all the test and got them passing.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LazaroOnline LazaroOnline changed the title Master Allow special characters in Assembly InformationalVersion Jun 24, 2020
@asbjornu
Copy link
Member

Thanks for this. But as I wrote in #2199 (comment), I'm hesitant to stop replacing special characters as consumers of the [AssemblyInformationalVersion] attribute generated by GitVersion may depend on special characters being replaced. See #2014 and #1520 for more information. I'll follow up the discussion with ideas for implementation in a non-breaking way in #2199.

@stale
Copy link

stale bot commented Sep 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 24, 2020
@stale stale bot closed this Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants