Allow special characters in Assembly InformationalVersion #2341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow any special character in Assembly InformationalVersion.
Added a parameter in the common function "CheckAndFormatString" to control whether or not special chars gets replaced.
New in 2nd commit:
Added a new config parameter:
assembly-informational-is-semver
that is true by default to make this backwards compatible.If set to false then it allows any character in
assembly-informational-version
.Related Issue
#2339
#2199
Motivation and Context
Allow any special character in Assembly InformationalVersion.
It is the only place we can add free long customized text describing anything we want and readable from dll/exe file properties.
How Has This Been Tested?
Included a test.
Run all the test and got them passing.
Checklist: