Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/di4 #2203

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Feature/di4 #2203

merged 4 commits into from
Mar 25, 2020

Conversation

arturcic
Copy link
Member

Continuation of #2200

Description

This PR adds IGitVersionTool interface that uses internally the GitVersionInformationGenerator, AssemblyInfoFileUpdater and WixVersionFileUpdater.

IGitVersionTool is then used by Exe and Task. This way the common code from Exe and Task is moved in Core

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic arturcic merged commit 522b6a4 into GitTools:master Mar 25, 2020
@arturcic arturcic added this to the 5.3.0 milestone Mar 25, 2020
@arturcic arturcic deleted the feature/di4 branch March 25, 2020 12:40
@github-actions
Copy link

github-actions bot commented May 4, 2020

🎉 This issue has been resolved in version 5.3.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant