Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGit2Sharp update to 0.26.0 (2) #1713

Merged
merged 8 commits into from
Jun 26, 2019

Conversation

arturcic
Copy link
Member

This is the re-implementation of #1659

@arturcic arturcic requested a review from asbjornu June 21, 2019 06:52
@arturcic arturcic added this to the 5.0.0 milestone Jun 21, 2019
@arturcic arturcic force-pushed the feature/libgit2sharp_latest branch from 28f0c32 to 152de0d Compare June 24, 2019 06:19
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! How is our dog-fooding on the produced artifacts now? Are we testing the Docker images properly?

@arturcic
Copy link
Member Author

Currently we test the windows docker images and the linux .net core images, the mono images are not tested (as the 0.26.0 version of Libgi2sharp does not work properly with mono). I have some progress on testing the other artifacts - the nuget packages, but a PR is not ready yet.

For testing the nuget packages (and probably the gem and vsix) I'll use some docker images - the debian/ubuntu/alpine will be the official images from microsoft, for fedora/centos custom base images. I'll create a separate repo under GitTools organization where the base images will be defined, and we'll use these images for testing the artifacts as well as as base images for the docker images we release with gitversion.

@asbjornu
Copy link
Member

Sounds great, @arturcic. I really appreciate the amount of work you put into this!

@mpritch599
Copy link

Thanks for your efforts @arturcic - really looking forward to getting our hands on this! Are you able to merge the code, and push out to the nuget.org feed too please?

@arturcic
Copy link
Member Author

Thanks for your efforts @arturcic - really looking forward to getting our hands on this! Are you able to merge the code, and push out to the nuget.org feed too please?

I prefer not to merge my PRs; and I want to add nuget packaging testing inside docker images, to test the packages from this PR. It could be part of this PR or of another PR.

@asbjornu asbjornu merged commit 4c9a8c4 into GitTools:master Jun 26, 2019
@asbjornu
Copy link
Member

I've merged this now as it provides enough value in and of itself. But another PR with NuGet packaging testing inside the Docker images would be really sweet!

@arturcic
Copy link
Member Author

@asbjornu, this is the repo with the base docker images I'll use in an upcoming PR for testing the packages and for docker images we deliver

@arturcic arturcic deleted the feature/libgit2sharp_latest branch June 26, 2019 14:35
@mpritch599
Copy link

Thanks all - that works a treat!
Version in nuget.org for anyone that's watching: 5.0.0-beta3-44

@asbjornu
Copy link
Member

Thanks for the information, @martin-pritchard. I'm glad it works.

@arturcic
Copy link
Member Author

I guess we need to validate it works for other bugs related to libgit2sharp version

@EwanNoble
Copy link

Looks like this has resolved a lot of issues! Is there any chance of getting the latest netcore build pushed to the task on Azure DevOps for further testing?

@arturcic
Copy link
Member Author

arturcic commented Jun 27, 2019

That's on my list before we release the 5.0.0 version

@EwanNoble
Copy link

That's on my list before we release the 5.0.0 version

Fantastic, will keep an eye out for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants