-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibGit2Sharp update to 0.26.0 (2) #1713
LibGit2Sharp update to 0.26.0 (2) #1713
Conversation
update to libgit2sharp 0.26.0
28f0c32
to
152de0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! How is our dog-fooding on the produced artifacts now? Are we testing the Docker images properly?
Currently we test the windows docker images and the linux .net core images, the mono images are not tested (as the 0.26.0 version of Libgi2sharp does not work properly with mono). I have some progress on testing the other artifacts - the nuget packages, but a PR is not ready yet. For testing the nuget packages (and probably the gem and vsix) I'll use some docker images - the debian/ubuntu/alpine will be the official images from microsoft, for fedora/centos custom base images. I'll create a separate repo under GitTools organization where the base images will be defined, and we'll use these images for testing the artifacts as well as as base images for the docker images we release with gitversion. |
Sounds great, @arturcic. I really appreciate the amount of work you put into this! |
Thanks for your efforts @arturcic - really looking forward to getting our hands on this! Are you able to merge the code, and push out to the nuget.org feed too please? |
I prefer not to merge my PRs; and I want to add nuget packaging testing inside docker images, to test the packages from this PR. It could be part of this PR or of another PR. |
I've merged this now as it provides enough value in and of itself. But another PR with NuGet packaging testing inside the Docker images would be really sweet! |
Thanks all - that works a treat! |
Thanks for the information, @martin-pritchard. I'm glad it works. |
I guess we need to validate it works for other bugs related to libgit2sharp version |
Looks like this has resolved a lot of issues! Is there any chance of getting the latest netcore build pushed to the task on Azure DevOps for further testing? |
That's on my list before we release the 5.0.0 version |
Fantastic, will keep an eye out for it |
This is the re-implementation of #1659