Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CS0436 may be present with InternalsVisibleTo #3606

Closed
Applesauce314 opened this issue Jun 19, 2023 · 5 comments · Fixed by #3619
Closed

[Bug] CS0436 may be present with InternalsVisibleTo #3606

Applesauce314 opened this issue Jun 19, 2023 · 5 comments · Fixed by #3619
Labels
Milestone

Comments

@Applesauce314
Copy link
Contributor

Describe the bug
When GitVersionTask was replace with GitVersion.MSBuild in 5.6.0 the issue described in #448 has reemerged.

Expected Behavior

Not sure, GitVersionTask -> GitVersion.MsBuild is obviously a breaking version change, but the inconsistent behavior does not appear to be documented. was this change in behavior intentional or an accidental regression between versions.

Actual Behavior

CS0436 is present if you try to use the GitVersionInformation when it is also present in a referenced project which exposes its internals to the current assembly with InternalsVisibleTo

@arturcic
Copy link
Member

@Applesauce314 can you please create a test solution that reproduces the issue, and then we can decide if/when to fix it. If we decide to do it, then it will be implemented in v6 release cycle.

@arturcic arturcic added this to the 6.x milestone Jun 26, 2023
@arturcic arturcic added stale and removed stale labels Jun 30, 2023
Applesauce314 pushed a commit to Applesauce314/GitVersion that referenced this issue Jul 5, 2023
@Applesauce314
Copy link
Contributor Author

repro repository

Apparently the change made for #448 only existed in version 3.2.1, version 4.0.0 was what actually returned to the original behavior.

my thoughts on "fixing" it would be to add a configuration option, that way it would not be a breaking change.

<GenerateGitVersionInformationInUniqueNamespace>true</GenerateGitVersionInformationInUniqueNamespace>

I have a fork I can turn into a pull request with the above suggestion included

@arturcic
Copy link
Member

arturcic commented Jul 5, 2023

Sure, please send the PR where we can discuss

@Applesauce314
Copy link
Contributor Author

pull request is #3619

I am not very happy with the way I handled the template for C♯, its kind of clunky,

@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-beta.4 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants