-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] tag-prefix still seems to be optionally considered #3282
Comments
Hi @andyfurniss4 - that PR was merged in version 5.11.0, but we have reverted it back in 5.11.1 as it was not working as intended |
Ah, I see. I had not noticed the reversion! Thank you for clarifying! Is there an existing issue to track the rework or shall we use this one for that purpose? |
If @AlexPykavy does not mind we can use this one |
Adding a link to rollback issue: #3273 |
I've tried to reproduce the #3273 issue but didn't succeed. Then I asked users who encountered the issue for help, but silence... @arturcic, @asbjornu, may I just repeat the same PR but this time to the |
As we are unable to get @cfauchere or @mglochsen to reply or assist us with testing, I suspect |
🎉 This issue has been resolved in version 6.0.0 🎉 Your GitReleaseManager bot 📦🚀 |
Describe the bug
After the changes made in #3216 , I was expecting my issue with tag-prefix to be fixed but that doesn't seem to have happened. The scenario is that I am working in a repo which already has some semver tags which are used to version an API. The format of these tags are like so:
We want to create an SDK Nuget package which we want to version independently.
Expected Behavior / Actual Behavior
I thought #3216 would allow me to specify a tag-prefix in my GitVersion.yml for my SDK version, meaning the existing tags would be ignored and GitVersion would fall back to counting the commits on the main branch, resulting in an initial version of
0.1.X
. However, after specifying a tag-prefix of[vV]
, it's still picking up the existing tags and determining the next version as2.9.X
.Steps to Reproduce
gitversion.yml
Create a bunch of semver tags with no prefix. Run GitVersion. Resulting version is not
0.1.X
Your Environment
Running in a GitHub workflow/action like so:
The text was updated successfully, but these errors were encountered: