Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 5.11.0 #3273

Closed
cfauchere opened this issue Nov 7, 2022 · 12 comments · Fixed by #3275
Closed

Regression in 5.11.0 #3273

cfauchere opened this issue Nov 7, 2022 · 12 comments · Fixed by #3275
Labels
Milestone

Comments

@cfauchere
Copy link

Describe the bug
There was no issue with 5.10.3. Inputs haven't changed. Switching to 5.11.0 I now get an error.
Failed to parse 22.10.0 into a Semantic Version
INFO [11/07/22 21:18:52:29] Done writing
##[error]SyntaxError: Unexpected end of JSON input

Expected Behavior

No error (backcompat)

Actual Behavior

See the error above.

Possible Fix

Steps to Reproduce

mode: ContinuousDeployment
assembly-versioning-scheme: MajorMinorPatchTag
tag-prefix: v20|20|v
next-version: 22.10.0
continuous-delivery-fallback-tag: ''
commit-message-incrementing: Disabled
ignore:
  sha: []
branches:
  develop:
    tag: alpha
    increment: None
    prevent-increment-of-merged-branch-version: true
  master:
    tag: ''
    increment: None
  release(/v):
    regex: '^release(/v)'
    tag: release
    source-branches: []
    increment: None
  cloud-release:
    regex: '^release[/-]'
    tag: useBranchName
    source-branches: []
    increment: None
  pull-request:
    tag: pr.
    increment: None
    tag-number-pattern: '[/-](?<number>\d+)[-/]'

Context

Build break.

Your Environment

Ubuntu
5.11.0

@cfauchere cfauchere added the bug label Nov 7, 2022
@MathBouma
Copy link

I am having the same issue

@Sara-chi
Copy link

Sara-chi commented Nov 8, 2022

Same here. We are running it from a devops pipeline. None of the pipline or gitversion settings have changed and I couldn't find anything in the documentation about needed changes, but maybe I missed it?
Setting the version to 5.10.3 fixed it for now, but yeah...

@mglochsen
Copy link
Contributor

Same issue here. Downgrading to 5.10.3 is a temporary solution.

@asbjornu
Copy link
Member

asbjornu commented Nov 8, 2022

I wonder if this may be caused by #3216? Perhaps it was not as backwards compatible as I first thought. If so, we need to rollback that change and fold it into v6 instead, @AlexPykavy.

@arturcic
Copy link
Member

arturcic commented Nov 8, 2022

@asbjornu, do you think we should revert this PR amd release 5.11.1?

@AlexPykavy
Copy link
Contributor

AlexPykavy commented Nov 8, 2022

@asbjornu, @arturcic, I've create a PR with the revert. I will analyze why it failed later on and after that create a new PR for v6 covering this case (if possible).

@asbjornu
Copy link
Member

asbjornu commented Nov 8, 2022

Excellent, thanks @AlexPykavy! 🙏🏼

@asbjornu, do you think we should revert this PR amd release 5.11.1?

Yes, @arturcic.

@asbjornu asbjornu added this to the 5.x milestone Nov 8, 2022
@asbjornu asbjornu linked a pull request Nov 8, 2022 that will close this issue
5 tasks
@arturcic
Copy link
Member

arturcic commented Nov 8, 2022

ok I merged the revert, a release will be created soon
Closed by #3275

@arturcic arturcic closed this as completed Nov 8, 2022
@arturcic arturcic modified the milestones: 5.x, 5.11.1 Nov 8, 2022
@arturcic
Copy link
Member

arturcic commented Nov 8, 2022

🎉 This issue has been resolved in version 5.11.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@arturcic
Copy link
Member

arturcic commented Nov 8, 2022

@cfauchere @MathBouma @Sara-chi @mglochsen can you check version 5.11.1?

@asbjornu asbjornu changed the title Regression ins 5.11.x Regression in 5.11.0 Nov 8, 2022
@mglochsen
Copy link
Contributor

@cfauchere @MathBouma @Sara-chi @mglochsen can you check version 5.11.1?

I can confirm that the parsing error I saw yesterday with version 5.11.0 does not occur anymore with 5.11.1

Thanks for the fast fix @arturcic @asbjornu @AlexPykavy

@AlexPykavy
Copy link
Contributor

@cfauchere , @mglochsen , could you please try to use 5.11.0 version and change tag-prefix to be wrapped with (...)? like (v20|20|v)??

Or just share the list of tag so I can reproduce the issue on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants