Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tag to label #1054

Closed
asbjornu opened this issue Oct 2, 2016 · 6 comments · Fixed by #3314 or #3315
Closed

Rename tag to label #1054

asbjornu opened this issue Oct 2, 2016 · 6 comments · Fixed by #3314 or #3315

Comments

@asbjornu
Copy link
Member

asbjornu commented Oct 2, 2016

In GitVersion, a tag is not the same thing as a Git tag, which I find a bit confusing. Wanting to reference a Git tag and use it as the value of the pre-release tag makes it even more confusing. It is currently not possible to do this, but discussions on Gitter might indicate that something like this would be very handy:

branches:
  release:
    tag: useLatestTagLabel

However, it would be easier to understand if we renamed the pre-release tag to label:

branches:
  release:
    label: useFromLatestTag

This would allow for alternating pre-release labels on the same branch, such that a beta could be promoted to rc and stay at rc without having to tag every commit on that branch.

Thoughts?

@JakeGinnivan
Copy link
Contributor

Maybe just pre-release, that is what semver.org calls it?

We can probably include this change in v4 if we move on it soon. Thoughts @asbjornu

@asbjornu
Copy link
Member Author

@JakeGinnivan: What SemVer says about this that I can find, is:

Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.

And:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version.

So it seems to call these pre-release strings for labels or identifiers. Perhaps pre-release-identifier or pre-release-label could work? I think just label works too, but identifier is too generic.

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@asbjornu
Copy link
Member Author

If no one objects, I'd like to conclude this discussion with renaming tag to label. PRs welcome. 😃 🙏

@HHobeck
Copy link
Contributor

HHobeck commented Sep 24, 2022

If no one objects, I'd like to conclude this discussion with renaming tag to label. PRs welcome.

I like your idea to rename it to label. :)

arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
arturcic added a commit that referenced this issue Dec 19, 2022
Implement #1054 - renamed tag => label
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
arturcic added a commit to arturcic/GitVersion that referenced this issue Dec 19, 2022
tag-pre-release-weight, tag-prefix, continuous-delivery-fallback-tag, tag-number-pattern, tag
@arturcic arturcic linked a pull request Dec 19, 2022 that will close this issue
arturcic added a commit that referenced this issue Dec 19, 2022
@arturcic arturcic modified the milestones: 6.x, 6.0.0-alpha.1 Dec 22, 2022
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants