Skip to content

Commit

Permalink
Update configuration.md and fix minor code review issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
HHobeck committed Feb 22, 2023
1 parent 4ebaf3b commit 59c3bd5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions docs/input/docs/reference/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ minor-version-bump-message: '\+semver:\s?(feature|minor)'
patch-version-bump-message: '\+semver:\s?(fix|patch)'
no-bump-message: '\+semver:\s?(none|skip)'
label-pre-release-weight: 60000
commit-date-format: yyyy-MM-dd
merge-message-formats: {}
update-build-number: true
semantic-version-format: Strict
branches:
develop:
mode: ContinuousDeployment
Expand Down Expand Up @@ -154,9 +158,6 @@ branches:
- support
ignore:
sha: []
commit-date-format: yyyy-MM-dd
merge-message-formats: {}
update-build-number: true
mode: ContinuousDelivery
label: '{BranchName}'
increment: Inherit
Expand All @@ -167,7 +168,6 @@ regex: ''
tracks-release-branches: false
is-release-branch: false
is-mainline: false

```
The details of the available options are as follows:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ public void ShouldPickUpVersionFromMainAfterReleaseBranchMergedBack()
// merge release into main
fixture.Checkout(MainBranch);
fixture.MergeNoFF("release/1.0.0");
//fixture.AssertFullSemverNew("1.0.1+2", configuration);
fixture.AssertFullSemver("1.0.1+2", configuration);

// create a misnamed feature branch (i.e. it uses the default configuration) from main and verify the version
fixture.BranchTo("misnamed");
Expand Down
4 changes: 2 additions & 2 deletions src/GitVersion.Core/Configuration/ConfigurationBuilderBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@ private static void ValidateConfiguration(GitVersionConfiguration configuration)

public record BranchMetaData
{
public string Name { get; set; }
public string Name { get; init; }

public string RegexPattern { get; set; }
public string RegexPattern { get; init; }
}
}

0 comments on commit 59c3bd5

Please sign in to comment.