Skip to content

Commit

Permalink
Fixing minor stuff, following @Inokinoki comments
Browse files Browse the repository at this point in the history
Co-authored-by: Inoki <[email protected]>
  • Loading branch information
Hartorn and Inokinoki committed Sep 22, 2023
1 parent 61ebb36 commit c467382
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion python-client/giskard/core/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def configured_validate_arguments(func):
Decorator to enforce a function args to be compatible with their type hints.
:return: A wrapper function decorated by pydantic validate_arguments configured to allow arbitrary types check.
"""
# https://docs.pydantic.dev/latest/usage/validation_decorator/
# https://docs.pydantic.dev/2.3/usage/validation_decorator/
# Actually, this is more than just validation
# If you check https://docs.pydantic.dev/latest/usage/validation_decorator/#coercion-and-strictness,
# this explains it will try to convert/coerce type to the type hinting
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def inner(func: Union[SlicingFunctionType, Type[SlicingFunction]]) -> SlicingFun
if inspect.isclass(func) and issubclass(func, SlicingFunction):
return func

return _wrap_slicing_function(func, row_level, cell_level)#()
return _wrap_slicing_function(func, row_level, cell_level)

if callable(_fn):
return functools.wraps(_fn)(inner(_fn))
Expand Down
2 changes: 0 additions & 2 deletions python-client/giskard/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ class Settings(BaseModel):
ws_path: str = "/ml-worker"
host: str = "localhost"
max_workers: int = 10
max_send_message_length_mb: int = 1024
max_receive_message_length_mb: int = 1024
loglevel: str = "INFO"
cache_dir: str = "cache"
disable_analytics: bool = False
Expand Down

0 comments on commit c467382

Please sign in to comment.