Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) added women-only opportunities filter #271

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

(feature) added women-only opportunities filter #271

wants to merge 2 commits into from

Conversation

skanda1395
Copy link

@skanda1395 skanda1395 commented Dec 23, 2021 •
edited
Loading

Description

A checkbox is provided to toggle this filter. When selected, women-only opportunities are displayed. Unselecting it will go back to the previous state (shows opportunities for all).

Fixed #179

Type of change

Please check options that are relevant to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have pulled the latest changes in the repository
  • I have squashed my commits
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@skanda1395
Copy link
Author

Consider this as a working draft. Let me know if any changes are required.

Manvityagi
Manvityagi requested changes Dec 27, 2021
View reviewed changes
Copy link
Member

@Manvityagi Manvityagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skanda1395,
The logic looks good, the UI of the checkbox could be changed to match the rest of the page.

  1. Increase the font size to what Opportunity Dropdown has.
  2. Change its position to top-right, aligning it with the dropdown. I have marked it in the ss attached to give you a better idea.

image

@skanda1395
Copy link
Author

Changes explanation:

  • Since the checkbox has a state moving it to the common components requires passing down the state onlyForWomen to the checkbox and have to update it from there and I thought this was complicated. Also, alignment of those two requires complex CSS in this scenario.
  • So, I cut the dropdown component out of common components and put it along side the checkbox.
  • Also, I tried the aligning the checkbox to the top-right, but the user experience would be better if we put them together I think.

Do take a look at my changes and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manvityagi Manvityagi Manvityagi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Girl specific opportunities
2 participants
@skanda1395 @Manvityagi